From: Jeff King <peff@peff.net>
Date: Tue, 30 Sep 2008 12:45:22 GMT
Subject: Re: [PATCH] tests: grep portability fixes
Message-ID: <20080930124522.GA22182@coredump.intra.peff.net>
In-Reply-To: <48E1FF6D.1050907@viscovery.net>

On Tue, Sep 30, 2008 at 12:29:01PM +0200, Johannes Sixt wrote:

> Andreas Ericsson schrieb:
> > Jeff King wrote:
> >> -    if ! grep -qe "Invalid gitfile format" .err
> >> +    if ! grep "Invalid gitfile format" .err
> > 
> > Doesn't output need to be redirected when you drop '-q'?
> 
> In standard mode, the test output is directed to /dev/null anyway, and in
> verbose mode the extra output doesn't hurt at all, and is usually useful
> because you know that a pattern matched.

Exactly. This is the more of the same as aadbe44f (grep portability fix:
don't use "e" or "-q") but I was too lazy to rewrite the justification
completely (but I did reference it).

-Peff