Re: [RFC 7/9] send-email: Completely replace --signed-off-cc with --signed-off-by-cc
- From
Jeff King <peff@peff.net>
- Date
- Sep 29, 2008, 16:29 UTC
- Message-ID
- <20080929162935.GA2628@coredump.intra.peff.net>
- In-Reply-To
- <1222664781-55763-2-git-send-email-mfwitten@mit.edu>
On Mon, Sep 29, 2008 at 12:06:19AM -0500, Michael Witten wrote:
> This breaks backwards compatibility, but so what---get off your > lazy arses and remove the cruft.
Sorry, but try to be a lot more careful than that about breaking compatibility. The right sequence is:
1. Introduce new option (which has already been done for the command
line, but it looks like you are adding a new config variable).Mention the new option in the documentation as the "right way".
Possibly mention the old version as "deprecated".
2. Wait a long time, possibly forever. This gives people a chance to
adjust, and it lets us wait for a major version bump where such an
incompatibility might be more expected.3. Remove the old option.
So I think you are skipping straight to '3' here. However, I think your real purpose is to simply clean up the documentation, so why not just do that? We can still support the old options for historical setups, and just advertise the new ones in the docs.
-Peff