Re: [PATCH 8/8] Docs: config: send-email config options included
- From
Jeff King <peff@peff.net>
- Date
- Sep 28, 2008, 19:06 UTC
- Message-ID
- <20080928190615.GA32380@coredump.intra.peff.net>
- In-Reply-To
- <C0DC4F74-6157-44AE-A25A-4C74A415CDDA@mit.edu>
On Sun, Sep 28, 2008 at 02:03:59PM -0500, Michael Witten wrote:
Show 11 quoted lines
>> Note that this list is non-comprehensive and not necessarily complete. >> For command-specific variables, you will find a more detailed >> description >> in the appropriate manual page. You will find a description of non-core >> porcelain configuration variables in the respective porcelain >> documentation. > > I think config.txt is not the place to put this stuff (though I've only > given it a quick glance), and include:: will just cause us to litter > the place with tool-config.txt include files, which looks yucky and is > subject to neglect.
Ah, I hadn't read that before. So yes, I agree that it should go into git-send-email.txt. I do think putting a note (similar to the one for imap.*) into config.txt would be a nice addition, but it is obviously independent of your other changes.
-Peff