[RFC 7/9] send-email: Completely replace --signed-off-cc with --signed-off-by-cc
- From
Michael Witten <mfwitten@mit.edu>
- Date
- Sep 29, 2008, 05:08 UTC
- Message-ID
- <1222664892-55810-2-git-send-email-mfwitten@mit.edu>
- In-Reply-To
- <1222664892-55810-1-git-send-email-mfwitten@mit.edu>
This breaks backwards compatibility, but so what---get off your lazy arses and remove the cruft.
Signed-off-by: Michael Witten <mfwitten@mit.edu> --- Documentation/git-send-email.txt | 2 +- git-send-email.perl | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt index 0d6ac4a..8ffe525 100644 --- a/Documentation/git-send-email.txt +++ b/Documentation/git-send-email.txt @@ -87,7 +87,7 @@ The --cc option must be repeated for each user you want on the cc list. --[no-]signed-off-by-cc:: If this is set, add emails found in Signed-off-by: or Cc: lines to the - cc list. Default is the value of 'sendemail.signedoffcc' configuration + cc list. Default is the value of 'sendemail.signedoffbycc' configuration value; if that is unspecified, default to --signed-off-by-cc. --smtp-encryption:: diff --git a/git-send-email.perl b/git-send-email.perl index 3467cf1..4662d28 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -144,7 +144,7 @@ if ($@) { my ($quiet, $dry_run) = (0, 0); # Variables with corresponding config settings -my ($thread, $chain_reply_to, $suppress_from, $signed_off_cc, $cc_cmd); +my ($thread, $chain_reply_to, $suppress_from, $signed_off_by_cc, $cc_cmd); my ($smtp_server, $smtp_server_port, $smtp_authuser, $smtp_encryption); my ($identity, $aliasfiletype, @alias_files, @smtp_host_parts); my ($validate); @@ -154,7 +154,7 @@ my %config_bool_settings = ( "thread" => [\$thread, 1], "chainreplyto" => [\$chain_reply_to, 1], "suppressfrom" => [\$suppress_from, undef], - "signedoffcc" => [\$signed_off_cc, undef], + "signedoffbycc" => [\$signed_off_by_cc, undef], "validate" => [\$validate, 1], ); @@ -218,7 +218,7 @@ my $rc = GetOptions("sender|from=s" => \$sender, "cc-cmd=s" => \$cc_cmd, "suppress-from!" => \$suppress_from, "suppress-cc=s" => \@suppress_cc, - "signed-off-cc|signed-off-by-cc!" => \$signed_off_cc, + "signed-off-by-cc!" => \$signed_off_by_cc, "dry-run" => \$dry_run, "envelope-sender=s" => \$envelope_sender, "thread!" => \$thread, @@ -294,7 +294,7 @@ if ($suppress_cc{'all'}) { # If explicit old-style ones are specified, they trump --suppress-cc. $suppress_cc{'self'} = $suppress_from if defined $suppress_from; -$suppress_cc{'sob'} = !$signed_off_cc if defined $signed_off_cc; +$suppress_cc{'sob'} = !$signed_off_by_cc if defined $signed_off_by_cc; # Debugging, print out the suppressions. if (0) {
-- 1.6.0.2.304.gdcf23.dirty