git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/4] cygwin: Use native Win32 API for stat

From
Dmitry Potapov <dpotapov@gmail.com>
Date
Sep 27, 2008, 16:33 UTC
Message-ID
<20080927163349.GE21650@dpotapov.dyndns.org>
In-Reply-To
<347507080809270851y79764dbcgba1ef5a1d58bdd3e@mail.gmail.com>
On Sat, Sep 27, 2008 at 11:51:24AM -0400, Marcus Griep wrote:
> 
> Overall, looks good, though Alex's comment of using "cygwin.nativestat" may
> be a better descriptor for the config flag.

Perhaps... but I am not sure about policy for options in config file. core.cygwinnativestat was proposed by Shawn, so I would like to hear his opinion.

> I also think there is more refactoring that could be done, with there being
> common code paths still existing in MinGW and Cygwin.

I am not sure that there is much common code left: stat structures are different in MinGW and Cygwin (different fields and their types), and I do not think having one function with a lot of #ifdef __CYGWIN__ in it is actual improvement. But you can send a patch on top of mine and let other people decide if it is a worty goal.

Dmitry
Previous: Alex Riesen
Message 11 of 11 in “cygwin: Use native Win32 API for stat”
  1. 4/4 cygwin: Use native Win32 API for statDmitry Potapov, Sep 27, 2008
  2. Johannes SixtSep 27, 2008
  3. Dmitry PotapovSep 27, 2008
  4. Johannes SixtSep 28, 2008
  5. Shawn O. PearceSep 29, 2008
  6. Dmitry PotapovSep 29, 2008
  7. 4/4 cygwin: Use native Win32 API for statDmitry Potapov, Sep 30, 2008
  8. Marcus GriepSep 30, 2008
  9. Shawn O. PearceSep 30, 2008
  10. Alex RiesenSep 28, 2008
  11. Dmitry PotapovSep 27, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.