git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv3 1/2] Make xdi_diff_outf interface for running xdiff_outf diffs

From
Brian Downing <bdowning@lavos.net>
Date
Aug 14, 2008, 06:34 UTC
Message-ID
<20080814063412.GF4396@lavos.net>
In-Reply-To
<7v1w0sf7bl.fsf@gitster.siamese.dyndns.org>
On Wed, Aug 13, 2008 at 11:18:22PM -0700, Junio C Hamano wrote:
Show 5 quoted lines
> I wonder if something like this on top of your patch would be worth doing
> as a further clean-up.
> 
> -- >8 --
> xdiff-interface: hide the whole "xdiff_emit_state" business from the caller
Nice, looks good to me.
-bcd
Previous: Junio C HamanoNext: Brian Downing
Message 11 of 14 in “Make xdiff_outf_{init,release} interface”
  1. 1/2 Make xdiff_outf_{init,release} interfaceBrian Downing, Aug 13, 2008
  2. Junio C HamanoAug 14, 2008
  3. Brian DowningAug 14, 2008
  4. Junio C HamanoAug 14, 2008
  5. 1/2 Make xdi_diff_outf interface for running xdiff_outf diffsBrian Downing, Aug 14, 2008
  6. 2/2 Use strbuf for struct xdiff_emit_state's remainderBrian Downing, Aug 14, 2008
  7. Brian DowningAug 14, 2008
  8. 1/2 Make xdi_diff_outf interface for running xdiff_outf diffsBrian Downing, Aug 14, 2008
  9. 2/2 Use strbuf for struct xdiff_emit_state's remainderBrian Downing, Aug 14, 2008
  10. Junio C HamanoAug 14, 2008
  11. Brian DowningAug 14, 2008
  12. Brian DowningAug 21, 2008
  13. Junio C HamanoAug 21, 2008
  14. Brian DowningAug 21, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.