git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv2 1/2] Make xdi_diff_outf interface for running xdiff_outf diffs

From
Brian Downing <bdowning@lavos.net>
Date
Aug 14, 2008, 05:31 UTC
Message-ID
<20080814053156.GE4396@lavos.net>
In-Reply-To
<1218690802-30536-1-git-send-email-bdowning@lavos.net>
On Thu, Aug 14, 2008 at 12:13:21AM -0500, Brian Downing wrote:
Show 12 quoted lines
> @@ -141,6 +141,17 @@ int xdi_diff(mmfile_t *mf1, mmfile_t *mf2, xpparam_t const *xpp, xdemitconf_t co
>  	return xdl_diff(&a, &b, xpp, xecfg, xecb);
>  }
>  
> +int xdi_diff_outf(mmfile_t *mf1, mmfile_t *mf2,
> +		  struct xdiff_emit_state *state, xpparam_t const *xpp,
> +		  xdemitconf_t const *xecfg, xdemitcb_t *xecb)
> +{
> +	int ret;
> +	xecb->outf = xdiff_outf;
> +	xecb->priv = state;
> +	ret = xdl_diff(mf1, mf2, xpp, xecfg, xecb);

Sorry, this was wrong. It should call xdi_diff. (Unfortunately, the tests passed anyway.) I'll resubmit.

Show 6 quoted lines
> +	return ret;
> +}
> +
>  int read_mmfile(mmfile_t *ptr, const char *filename)
>  {
>  	struct stat st;
-bcd
Previous: Brian DowningNext: Brian Downing
Message 7 of 14 in “Make xdiff_outf_{init,release} interface”
  1. 1/2 Make xdiff_outf_{init,release} interfaceBrian Downing, Aug 13, 2008
  2. Junio C HamanoAug 14, 2008
  3. Brian DowningAug 14, 2008
  4. Junio C HamanoAug 14, 2008
  5. 1/2 Make xdi_diff_outf interface for running xdiff_outf diffsBrian Downing, Aug 14, 2008
  6. 2/2 Use strbuf for struct xdiff_emit_state's remainderBrian Downing, Aug 14, 2008
  7. Brian DowningAug 14, 2008
  8. 1/2 Make xdi_diff_outf interface for running xdiff_outf diffsBrian Downing, Aug 14, 2008
  9. 2/2 Use strbuf for struct xdiff_emit_state's remainderBrian Downing, Aug 14, 2008
  10. Junio C HamanoAug 14, 2008
  11. Brian DowningAug 14, 2008
  12. Brian DowningAug 21, 2008
  13. Junio C HamanoAug 21, 2008
  14. Brian DowningAug 21, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.