From: Brian Downing Date: Thu, 14 Aug 2008 06:34:12 GMT Subject: Re: [PATCHv3 1/2] Make xdi_diff_outf interface for running xdiff_outf diffs Message-ID: <20080814063412.GF4396@lavos.net> In-Reply-To: <7v1w0sf7bl.fsf@gitster.siamese.dyndns.org> On Wed, Aug 13, 2008 at 11:18:22PM -0700, Junio C Hamano wrote: > I wonder if something like this on top of your patch would be worth doing > as a further clean-up. > > -- >8 -- > xdiff-interface: hide the whole "xdiff_emit_state" business from the caller Nice, looks good to me. -bcd