Re: RFC: Allow missing objects during packing

From: Shawn O. Pearce <spearce@spearce.org>
Date: Aug 11, 2008, 22:44 UTC
Message-ID: <20080811224404.GQ26363@spearce.org>
In-Reply-To: <7vk5enuqfg.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> wrote:

Show 11 quoted lines

> "Shawn O. Pearce" <spearce@spearce.org> writes:
> 
> > ... It seems pretty harmless to allow an object we
> > aren't going to transmit but that we want to use as a delta base
> > in a thin pack to be missing.  At worst we just get a little bit
> > more data transfer.
> 
> If the check is only about a thin delta base that is not going to be
> transmit, I'd agree.  But I do not see how you are distinguishing that
> case and the case where an object you are actually sending is missing (in
> which case we would want to error out, wouldn't we?)

Arrgh. Good catch. My patch is flawed in that it does not correctly fail if we really needed the missing object in this output pack.

I don't think that would be hard to fix. I'll respin something shortly.

-- 
Shawn.