git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] bash completion: Add long options for 'git describe'

From
Thomas Rast <trast@student.ethz.ch>
Date
Jul 26, 2008, 10:25 UTC
Message-ID
<200807261225.13949.trast@student.ethz.ch>
In-Reply-To
<20080725162028.GB21117@spearce.org>
Shawn O. Pearce wrote:
Show 9 quoted lines
> SZEDER GGGbor <szeder@ira.uka.de> wrote:
> > >  _git_describe ()
> > >  {
> > > +	__git_has_doubledash && return
> > This line is superfluous, because 'git describe' does not have any path
> > arguments.
> 
> Yup.  Aside from the two items described above (mising SOB line
> and the unnecessary double dash test) this patch looks fine.

I suppose you're right. It does (empirically) attempt to parse anything following a -- as a revision argument, but similar commands like cherry-pick don't handle the -- specially either.

I'll resend a fixed version.
- Thomas
-- 
Thomas Rast
trast@student.ethz.ch
Previous: Shawn O. PearceNext: Thomas Rast
Message 4 of 6 in “bash completion: Add long options for 'git describe'”
  1. bash completion: Add long options for 'git describe'Thomas Rast, Jul 25, 2008
  2. SZEDER GáborJul 25, 2008
  3. Shawn O. PearceJul 25, 2008
  4. Thomas RastJul 26, 2008
  5. bash completion: Add long options for 'git describe'Thomas Rast, Jul 26, 2008
  6. Shawn O. PearceJul 26, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.