git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] bash completion: Add long options for 'git describe'

From
Shawn O. Pearce <spearce@spearce.org>
Date
Jul 25, 2008, 16:20 UTC
Message-ID
<20080725162028.GB21117@spearce.org>
In-Reply-To
<20080725131532.GB6701@neumann>
SZEDER GGGbor <szeder@ira.uka.de> wrote:
Show 9 quoted lines
> On Fri, Jul 25, 2008 at 12:02:50PM +0200, Thomas Rast wrote:
> > ---
> Signed off by?
> 
> >  _git_describe ()
> >  {
> > +	__git_has_doubledash && return
> This line is superfluous, because 'git describe' does not have any path
> arguments.

Yup. Aside from the two items described above (mising SOB line and the unnecessary double dash test) this patch looks fine.

-- 
Shawn.
Previous: SZEDER GáborNext: Thomas Rast
Message 3 of 6 in “bash completion: Add long options for 'git describe'”
  1. bash completion: Add long options for 'git describe'Thomas Rast, Jul 25, 2008
  2. SZEDER GáborJul 25, 2008
  3. Shawn O. PearceJul 25, 2008
  4. Thomas RastJul 26, 2008
  5. bash completion: Add long options for 'git describe'Thomas Rast, Jul 26, 2008
  6. Shawn O. PearceJul 26, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.