From: Thomas Rast <trast@student.ethz.ch>
Date: Sat, 26 Jul 2008 10:25:05 GMT
Subject: Re: [PATCH] bash completion: Add long options for 'git describe'
Message-ID: <200807261225.13949.trast@student.ethz.ch>
In-Reply-To: <20080725162028.GB21117@spearce.org>

Shawn O. Pearce wrote:
> SZEDER GGGbor <szeder@ira.uka.de> wrote:
> > >  _git_describe ()
> > >  {
> > > +	__git_has_doubledash && return
> > This line is superfluous, because 'git describe' does not have any path
> > arguments.
> 
> Yup.  Aside from the two items described above (mising SOB line
> and the unnecessary double dash test) this patch looks fine.

I suppose you're right.  It does (empirically) attempt to parse
anything following a -- as a revision argument, but similar commands
like cherry-pick don't handle the -- specially either.

I'll resend a fixed version.

- Thomas

-- 
Thomas Rast
trast@student.ethz.ch