From: Jeff King <peff@peff.net>
Date: Fri, 25 Jul 2008 18:38:57 GMT
Subject: Re: [PATCH] Avoid warning when From: is encoded
Message-ID: <20080725183857.GE4375@sigill.intra.peff.net>
In-Reply-To: <7vhcadudmz.fsf@gitster.siamese.dyndns.org>

On Fri, Jul 25, 2008 at 09:33:56AM -0700, Junio C Hamano wrote:

> > In commit 0706bd19ef9b41e7519df2c73796ef93484272fd $1 is used from a regexp
> > without using () to set up $1. Later, when that value was used, it caused a
> > warning about a variable being undefined.
> >
> > Signed-off-by: Peter Valdemar Mørch <peter@morch.com>
> 
> Thanks.  The patch is obviously correct; I think you are fixing 8291db6
> (git-send-email: add charset header if we add encoded 'From', 2007-11-16),
> not 0706bd1 (send-email: specify content-type of --compose body,
> 2008-03-28).
> 
> Will apply to maint and merge upwards.

Discussions about who can ACK this code aside, the original bogosity was
totally mine, so

  Acked-by: Jeff King <peff@peff.net>

-Peff