From: Shawn O. Pearce <spearce@spearce.org>
Date: Fri, 25 Jul 2008 16:20:28 GMT
Subject: Re: [PATCH] bash completion: Add long options for 'git describe'
Message-ID: <20080725162028.GB21117@spearce.org>
In-Reply-To: <20080725131532.GB6701@neumann>

SZEDER GGGbor <szeder@ira.uka.de> wrote:
> On Fri, Jul 25, 2008 at 12:02:50PM +0200, Thomas Rast wrote:
> > ---
> Signed off by?
> 
> >  _git_describe ()
> >  {
> > +	__git_has_doubledash && return
> This line is superfluous, because 'git describe' does not have any path
> arguments.

Yup.  Aside from the two items described above (mising SOB line
and the unnecessary double dash test) this patch looks fine.

-- 
Shawn.