Re: [PATCH] Ensure that SSH runs in non-interactive mode

From: Jeff King <peff@peff.net>
Date: Jul 21, 2008, 07:05 UTC
Message-ID: <20080721070517.GB2080@sigill.intra.peff.net>
In-Reply-To: <20080721065348.GB24608@glandium.org>

On Mon, Jul 21, 2008 at 08:53:48AM +0200, Mike Hommey wrote:

> I'm not sure the ControlMaster option is still followed when using -T.

It is still followed.

> Also, IIRC, ControlMaster doesn't exit until slave connections are
> done, so git ssh sessions granted the master control would stall until
> then if they happen to have slaves launched. i.e. It can *already* have
> bad side effects.

Yes, that is a problem (and IMHO a weakness in the implementation, but obviously not git's problem at all).

> Adding '-S none' would ensure ControlMaster would not take effect; on

I think that is definitely a mistake; git is one of the main reasons I use ControlMaster in the first place.

> the other hand, it would not allow git's ssh connection to be a slave
> either. '-o ControlMaster no' could be a solution.

That is actually quite sensible, and would make this a non-issue, as far as I can see.

> All these need to be tested, obviously.

I tested, and doing "ssh -Tx -o 'ControlMaster no'" does the right thing (reuse existing session if possible, create a new one with -Tx otherwise, and never create a control socket for slaves).

-Peff