Re: [PATCH] Ensure that SSH runs in non-interactive mode
- From
Mike Hommey <mh@glandium.org>
- Date
- Jul 19, 2008, 17:52 UTC
- Message-ID
- <20080719175210.GA7835@glandium.org>
- In-Reply-To
- <1216487215-6927-1-git-send-email-fredrik@dolda2000.com>
On Sat, Jul 19, 2008 at 07:06:55PM +0200, Fredrik Tolf wrote:
Show 13 quoted lines
> OpenSSH has the nice feature that it sets the IP TOS value of its > connection depending on usage. When used in interactive mode, it > is set to Minimize-Delay, and other wise to Maximize-Throughput. Its > usage by Git is best served by Maximize-Throughput, for obvious > reasons. > > However, it seems to use a DWIM heuristic for detecting interactive > mode. The current implementation enters interactive mode if either > a PTY is allocated or X11 forwarding is enabled, and even though Git > SSH:ing does not allocate a PTY, X11 forwarding is often turned on > by default. By removing the DISPLAY env variable before forking, SSH > can thus be forced into non-interactive mode, without any obvious > ill effects.
Wouldn't adding the -x option be better ? Also adding -T could be a good idea.
Mike