git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fetch: report local storage errors in status table

From
Jeff King <peff@peff.net>
Date
Jun 28, 2008, 04:21 UTC
Message-ID
<20080628042114.GB9451@sigill.intra.peff.net>
In-Reply-To
<7vprq2moua.fsf@gitster.siamese.dyndns.org>
On Fri, Jun 27, 2008 at 04:37:33PM -0700, Junio C Hamano wrote:
Show 9 quoted lines
> > With this patch, the output takes into account the status of
> > updating the local ref:
> >
> >   error: there are still refs under 'refs/remotes/origin/foo'
> >   From $url_of_repo
> >    ! [new branch]      foo        -> origin/foo  (unable to update local ref)
>
> Makes sense --- thanks.  This is something we can have automated tests,
> isn't it?

We don't currently have any tests for either the fetch output or the push output. Note that we aren't changing the output _status_. Fetch always knew that this condition was a failure, and exited appropriately. So it really would just be testing the expected human-readable output in these situations, something I thought we usually didn't include in the tests.

But if you think it is worth doing, I can whip up a few tests.
-Peff
Previous: Junio C HamanoNext: Jeff King
Message 8 of 13 in “bug related to branches using / in name”
  1. Simon Holm ThøgersenJun 26, 2008
  2. Jeff KingJun 27, 2008
  3. Jeff KingJun 27, 2008
  4. Simon Holm ThøgersenJun 27, 2008
  5. Jeff KingJun 27, 2008
  6. fetch: report local storage errors in status tableJeff King, Jun 27, 2008
  7. Junio C HamanoJun 27, 2008
  8. Jeff KingJun 28, 2008
  9. 2/2 fetch: give a hint to the user when local refs fail to updateJeff King, Jun 27, 2008
  10. Junio C HamanoJun 27, 2008
  11. Jeff KingJun 28, 2008
  12. Junio C HamanoJun 28, 2008
  13. Jakub NarebskiJun 28, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.