Re: [PATCH] fetch: report local storage errors in status table
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 27, 2008, 23:37 UTC
- Message-ID
- <7vprq2moua.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20080627035950.GA21382@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 19 quoted lines
> Previously, if there was an error while storing a local > tracking ref, the low-level functions would report an error, > but fetch's status output wouldn't indicate any problem. > E.g., imagine you have an old "refs/remotes/origin/foo/bar" but > upstream has deleted "foo/bar" in favor of a new branch > "foo". You would get output like this: > > error: there are still refs under 'refs/remotes/origin/foo' > From $url_of_repo > * [new branch] foo -> origin/foo > > With this patch, the output takes into account the status of > updating the local ref: > > error: there are still refs under 'refs/remotes/origin/foo' > From $url_of_repo > ! [new branch] foo -> origin/foo (unable to update local ref) > > Signed-off-by: Jeff King <peff@peff.net>
Makes sense --- thanks. This is something we can have automated tests, isn't it?