From: Jeff King <peff@peff.net>
Date: Sat, 28 Jun 2008 04:21:15 GMT
Subject: Re: [PATCH] fetch: report local storage errors in status table
Message-ID: <20080628042114.GB9451@sigill.intra.peff.net>
In-Reply-To: <7vprq2moua.fsf@gitster.siamese.dyndns.org>

On Fri, Jun 27, 2008 at 04:37:33PM -0700, Junio C Hamano wrote:

> > With this patch, the output takes into account the status of
> > updating the local ref:
> >
> >   error: there are still refs under 'refs/remotes/origin/foo'
> >   From $url_of_repo
> >    ! [new branch]      foo        -> origin/foo  (unable to update local ref)
>
> Makes sense --- thanks.  This is something we can have automated tests,
> isn't it?

We don't currently have any tests for either the fetch output or the
push output. Note that we aren't changing the output _status_. Fetch
always knew that this condition was a failure, and exited appropriately.
So it really would just be testing the expected human-readable output in
these situations, something I thought we usually didn't include in the
tests.

But if you think it is worth doing, I can whip up a few tests.

-Peff