Re: [PATCH] Add test-tr: poor-man tr
- From
Jeff King <peff@peff.net>
- Date
- Jun 13, 2008, 06:02 UTC
- Message-ID
- <20080613060215.GB26768@sigill.intra.peff.net>
- In-Reply-To
- <20080612203245.GB8057@steel.home>
On Thu, Jun 12, 2008 at 10:32:45PM +0200, Alex Riesen wrote:
Show 7 quoted lines
> That was the problem. ActiveState Perl always replaces LF in the > output with CRLF, which caused mismatches with template files in some > tests (even the generated templates had LF line endings, cygwins tools > follow that convention). At first, I tried to get by putting > "binmode(STDOUT)" into every test, but this became boring with a time. > Besides, the lines get very long and ugly (and make conflict resolving > harder).
Does ActiveState respect the PERLIO environment variable? I haven't played with it much, but my understanding is that setting PERLIO=:unix:perlio should give you sane behavior (the default on Windows should be PERLIO=:unix:crlf).
> > So I am not opposed to test-tr, I just wanted you to explain it better > > in the commit log. ;) > > I already tried.
I think this thread and the improved commit message have helped.
-Peff