git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add test-tr: poor-man tr

From
Jeff King <peff@peff.net>
Date
Jun 11, 2008, 22:54 UTC
Message-ID
<20080611225448.GC19474@sigill.intra.peff.net>
In-Reply-To
<20080611182501.GA3344@steel.home>
On Wed, Jun 11, 2008 at 08:25:01PM +0200, Alex Riesen wrote:
Show 10 quoted lines
> It offers a limited set of POSIX tr, in particular: no character class
> support and no [n*m] operators. Only 8bit. C-escapes supported, and
> character ranges. Deletion and squeezing should work, but -s does not
> match the GNU tr from coreutils (which, in turn, does not match POSIX).
> 
> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
> ---
> 
> Rebased on top of current master. I still think it makes the test
> suite more portable.

Having wrestled with Solaris tr, I can understand where you are coming from. However, does this _actually_ increase the portability of the test suite? That is, are there failing tests that this fixes, and if so, for which platforms (getting a successful run of the test suite on Solaris is still on my long-term todo, but I thought I had fixed all of the tr issues)?

Or is your rationale "this will prevent people from screwing up the test scripts accidentally in the future"?

I am not opposed to the latter, but I think it makes sense to state it clearly in the commit message.

-Peff
Previous: Alex RiesenNext: Alex Riesen
Message 4 of 14 in “Add test-tr: poor-man tr”
  1. Add test-tr: poor-man trAlex Riesen, Jun 11, 2008
  2. Use test-tr in the testsAlex Riesen, Jun 11, 2008
  3. Alex RiesenJun 11, 2008
  4. Jeff KingJun 11, 2008
  5. Alex RiesenJun 12, 2008
  6. Jeff KingJun 12, 2008
  7. Jeff KingJun 12, 2008
  8. Alex RiesenJun 12, 2008
  9. Jeff KingJun 13, 2008
  10. Alex RiesenJun 13, 2008
  11. Jeff KingJun 13, 2008
  12. Alf ClementJun 12, 2008
  13. Johannes SchindelinJun 12, 2008
  14. Add test-tr: poor-man trAlex Riesen, Jun 12, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.