git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add test-tr: poor-man tr

From
Alex Riesen <raa.lkml@gmail.com>
Date
Jun 12, 2008, 20:32 UTC
Message-ID
<20080612203245.GB8057@steel.home>
In-Reply-To
<20080612062309.GA31816@sigill.intra.peff.net>
Jeff King, Thu, Jun 12, 2008 08:23:09 +0200:
Show 10 quoted lines
> On Thu, Jun 12, 2008 at 08:01:52AM +0200, Alex Riesen wrote:
> 
> > Frankly, it started because I wanted to minimize use of Perl on
> > Windows (because I can't get around ActiveState Perl at work, and it
> > breaks almost everything it touches). Accidentally, it is also faster
> > there (maybe just because it's smaller).
> 
> Ah, right. Well, I am not opposed to getting rid of perl in the test
> scripts (there is core functionality provided by perl, so one can easily
> run git on a system with no perl at all).

"git add --interactive" and "git send-mail". The first has a very good replacement (git gui). The other, even if not that "core", is a very popular tool. (And I can't use it at work at all: noone to understand word "patch" there. And even then, noone would care about change review anyway).

> However, even with your patch, there is still some perl left, so I am
> not sure that it has really bought us very much.

I was forced to carefully check every instance and am positive that the others are ok with regard to ActiveState Perl and Windows quirks :) (IOW, I run the testsuite every day and it aint broke yet)

Show 6 quoted lines
> > But, as was already noted, tr does not behave the same for all
> > platforms (there were even differences in output, BSD or Solaris put
> > out a stray LF?).
> 
> I think those were all resolved by using perl, and your patch replaces
> them with test-tr.

That was the problem. ActiveState Perl always replaces LF in the output with CRLF, which caused mismatches with template files in some tests (even the generated templates had LF line endings, cygwins tools follow that convention). At first, I tried to get by putting "binmode(STDOUT)" into every test, but this became boring with a time. Besides, the lines get very long and ugly (and make conflict resolving harder).

Show 9 quoted lines
> > In any case, I wont push this change too hard. I must admit, that
> > there is no real good reason besides one "screwed" company using
> > obsoleted tools in a weird way. And it is a maintenance effort (and
> > people will forget to use test-tr instead of perl and tr).
> 
> There is maintenance effort either way; people need to know not to do
> unportable things with tr (and other tools), and the solution to that is
> to run the test scripts on each platform (something we are starting to
> do).

With test-tr they still have to do all that, but also support its existence. So I'm not sure.

> So I am not opposed to test-tr, I just wanted you to explain it better
> in the commit log. ;)
I already tried.
Previous: Jeff KingNext: Jeff King
Message 8 of 14 in “Add test-tr: poor-man tr”
  1. Add test-tr: poor-man trAlex Riesen, Jun 11, 2008
  2. Use test-tr in the testsAlex Riesen, Jun 11, 2008
  3. Alex RiesenJun 11, 2008
  4. Jeff KingJun 11, 2008
  5. Alex RiesenJun 12, 2008
  6. Jeff KingJun 12, 2008
  7. Jeff KingJun 12, 2008
  8. Alex RiesenJun 12, 2008
  9. Jeff KingJun 13, 2008
  10. Alex RiesenJun 13, 2008
  11. Jeff KingJun 13, 2008
  12. Alf ClementJun 12, 2008
  13. Johannes SchindelinJun 12, 2008
  14. Add test-tr: poor-man trAlex Riesen, Jun 12, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.