git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] cvsimport: miscellaneous packed-ref fixes

From
Jeff King <peff@peff.net>
Date
Nov 29, 2007, 14:19 UTC
Message-ID
<20071129141938.GB32670@coredump.intra.peff.net>
In-Reply-To
<7vsl2pzxdf.fsf@gitster.siamese.dyndns.org>
On Wed, Nov 28, 2007 at 04:52:28PM -0800, Junio C Hamano wrote:
Show 8 quoted lines
> > @@ -998,7 +996,7 @@ if ($orig_branch) {
> >  	$orig_branch = "master";
> >  	print "DONE; creating $orig_branch branch\n" if $opt_v;
> >  	system("git-update-ref", "refs/heads/master", "$remote/$opt_o")
> > -		unless -f "$git_dir/refs/heads/master";
> > +		defined get_headref('refs/heads/master');
> 
> Where did the unless go ;-)?

Bah, I even ran this through the test suite, but obviously forgot a 'make' in the middle.

> Thanks, queued.

Thanks. Sorry for all the mistakes; I think I made more work in catching my errors than went into the original patch series. ;)

-Peff
Previous: Junio C HamanoNext: Emanuele Giaquinta
Message 15 of 16 in “Re: git-cvsimport bug”
  1. Jeff KingNov 28, 2007
  2. 1/3 Add basic cvsimport testsJeff King, Nov 28, 2007
  3. Junio C HamanoNov 28, 2007
  4. David KastrupNov 28, 2007
  5. Andreas EricssonNov 29, 2007
  6. 2/3 cvsimport: use show-ref to support packed refsJeff King, Nov 28, 2007
  7. Johannes SchindelinNov 28, 2007
  8. Jeff KingNov 28, 2007
  9. Johannes SchindelinNov 28, 2007
  10. Junio C HamanoNov 28, 2007
  11. Jeff KingNov 28, 2007
  12. Jeff KingNov 28, 2007
  13. 3/3 cvsimport: miscellaneous packed-ref fixesJeff King, Nov 28, 2007
  14. Junio C HamanoNov 29, 2007
  15. Jeff KingNov 29, 2007
  16. Emanuele GiaquintaNov 30, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.