From: Jeff King <peff@peff.net>
Date: Thu, 29 Nov 2007 14:19:38 GMT
Subject: Re: [PATCH 3/3] cvsimport: miscellaneous packed-ref fixes
Message-ID: <20071129141938.GB32670@coredump.intra.peff.net>
In-Reply-To: <7vsl2pzxdf.fsf@gitster.siamese.dyndns.org>

On Wed, Nov 28, 2007 at 04:52:28PM -0800, Junio C Hamano wrote:

> > @@ -998,7 +996,7 @@ if ($orig_branch) {
> >  	$orig_branch = "master";
> >  	print "DONE; creating $orig_branch branch\n" if $opt_v;
> >  	system("git-update-ref", "refs/heads/master", "$remote/$opt_o")
> > -		unless -f "$git_dir/refs/heads/master";
> > +		defined get_headref('refs/heads/master');
> 
> Where did the unless go ;-)?

Bah, I even ran this through the test suite, but obviously forgot a
'make' in the middle.

> Thanks, queued.

Thanks. Sorry for all the mistakes; I think I made more work in catching
my errors than went into the original patch series. ;)

-Peff