Re: [PATCH 2/3] cvsimport: use show-ref to support packed refs
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Nov 28, 2007, 19:16 UTC
- Message-ID
- <Pine.LNX.4.64.0711281916140.27959@racer.site>
- In-Reply-To
- <20071128185611.GB11320@coredump.intra.peff.net>
Hi,
On Wed, 28 Nov 2007, Jeff King wrote:
Show 27 quoted lines
> diff --git a/git-cvsimport.perl b/git-cvsimport.perl
> index efa6a0c..b852f2f 100755
> --- a/git-cvsimport.perl
> +++ b/git-cvsimport.perl
> @@ -527,18 +527,12 @@ sub is_sha1 {
> return $s =~ /^[a-f0-9]{40}$/;
> }
>
> -sub get_headref ($$) {
> - my $name = shift;
> - my $git_dir = shift;
> -
> - my $f = "$git_dir/$remote/$name";
> - if (open(my $fh, $f)) {
> - chomp(my $r = <$fh>);
> - is_sha1($r) or die "Cannot get head id for $name ($r): $!";
> - return $r;
> - }
> - die "unable to open $f: $!" unless $! == POSIX::ENOENT;
> - return undef;
> +sub get_headref ($) {
> + my $name = shift;
> + my $r = `git show-ref -s '$name'`;
> + return undef unless $? == 0;
> + chomp $r;
> + return $r;
> }Where has $remote gone?
Ciao, Dscho