Re: [PATCH 6/7] walk $PATH to generate list of commands for "help -a"
- From
Scott Parish <srp@srparish.net>
- Date
- Oct 28, 2007, 11:15 UTC
- Message-ID
- <20071028111517.GB7749@srparish.net>
- In-Reply-To
- <7vodejv9gt.fsf@gitster.siamese.dyndns.org>
On Sun, Oct 28, 2007 at 03:07:14AM -0700, Junio C Hamano wrote:
Show 21 quoted lines
> Scott Parish <sRp@srparish.net> writes: > > > On Sat, Oct 27, 2007 at 11:18:02PM -0700, Junio C Hamano wrote: > > > >> > We walk all the paths in $PATH collecting the names of "git-*" > >> > commands. To help distinguish between the main git commands > >> > and commands picked up elsewhere (probably extensions) we > >> > print them seperately. The main commands are the ones that > >> > are found in the first directory in $PATH that contains the > >> > "git" binary. > >> ... > > Its not clear to me what exactly you're looking for me to change, > > just the wording i'm using in my comment? Or are you refering to > > the approach? > > "git" binary will be found as /usr/bin/git while git-foo will be > found as /usr/libexec/git/git-foo in such an installation that > takes advantage of $(gitexecdir). And /usr/libexec/git/git will > not exist. Using existence of /usr/bin/git (I am referring to > your 'first directory on $PATH that contains the "git" binary' > above) as the cue for the location of "main commands" is wrong.
Thanks for the clarification, that would be a problem. I've modified the patch to list the main commands from git_exec_path(); i have mixed feelings, but curious what you think.
sRp
-- Scott Parish http://srparish.net/