From: Shawn O. Pearce Date: Fri, 07 Sep 2007 04:58:33 GMT Subject: Re: [PATCH 2/2] git-tag -s must fail if gpg is broken and cannot sign tags Message-ID: <20070907045833.GZ18160@spearce.org> In-Reply-To: <7vd4wwe2n5.fsf@gitster.siamese.dyndns.org> Junio C Hamano wrote: > "Shawn O. Pearce" writes: > > > "Shawn O. Pearce" wrote: > >> If the user has misconfigured `user.signingkey` in their .git/config > >> or just doesn't have any secret keys on their keyring and they ask > >> for a signed tag with `git tag -s` we better make sure the resulting > >> tag was actually signed by gpg. > > This seems to fail the test depending on the order processes > happen to be scheduled. I haven't looked at it closely yet. That's not good. I noticed stepping through the code last night that if gpg is misconfigured (e.g. set a bad user.signingkey in .git/config) it will terminate and send SIGPIPE to git-tag, which makes it terminate. All my change did was implement proper error handling. So if you are seeing failures now then we probably have a problem with the code without my patch too... -- Shawn.