git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git.__remotes_from_dir() should only return lists

From
Karl Hasselström <kha@treskal.com>
Date
Sep 6, 2007, 11:26 UTC
Message-ID
<20070906112645.GA31888@diana.vm.bytemark.co.uk>
In-Reply-To
<20070905165722.17744.56584.stgit@dv.roinet.com>
On 2007-09-05 12:57:22 -0400, Pavel Roskin wrote:
> If there are no remotes, return empty list, not None. The later
> doesn't work with builtin set().

Thanks. But I guess an even nicer fix would be to make this function return a set in the first place.

> This fixes t1001-branch-rename.sh

Hmm. I don't believe I saw t1001 break without this patch (I run the test suite before I push, but I might have made a mistake of course). Does the user's environment leak into the test sandbox?

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle
Previous: Pavel RoskinNext: Pavel Roskin
Message 2 of 5 in “git.__remotes_from_dir() should only return lists”
  1. git.__remotes_from_dir() should only return listsPavel Roskin, Sep 5, 2007
  2. Karl HasselströmSep 6, 2007
  3. Pavel RoskinSep 6, 2007
  4. Karl HasselströmSep 6, 2007
  5. Karl HasselströmSep 6, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.