From: Karl Hasselström Date: Thu, 06 Sep 2007 11:26:45 GMT Subject: Re: [PATCH] git.__remotes_from_dir() should only return lists Message-ID: <20070906112645.GA31888@diana.vm.bytemark.co.uk> In-Reply-To: <20070905165722.17744.56584.stgit@dv.roinet.com> On 2007-09-05 12:57:22 -0400, Pavel Roskin wrote: > If there are no remotes, return empty list, not None. The later > doesn't work with builtin set(). Thanks. But I guess an even nicer fix would be to make this function return a set in the first place. > This fixes t1001-branch-rename.sh Hmm. I don't believe I saw t1001 break without this patch (I run the test suite before I push, but I might have made a mistake of course). Does the user's environment leak into the test sandbox? -- Karl Hasselström, kha@treskal.com www.treskal.com/kalle