Re: [PATCH] git.__remotes_from_dir() should only return lists
- From
Karl Hasselström <kha@treskal.com>
- Date
- Sep 6, 2007, 23:11 UTC
- Message-ID
- <20070906231119.GB11829@diana.vm.bytemark.co.uk>
- In-Reply-To
- <1189082306.3695.5.camel@gx>
On 2007-09-06 08:38:26 -0400, Pavel Roskin wrote:
Show 9 quoted lines
> On Thu, 2007-09-06 at 13:26 +0200, Karl Hasselström wrote: > > > Hmm. I don't believe I saw t1001 break without this patch (I run > > the test suite before I push, but I might have made a mistake of > > course). Does the user's environment leak into the test sandbox? > > I don't think it's the user environment, at least on my side. I'm > using Fedora 7, which has python-2.5-12.fc7. That's the error from > the t1001 before my patch:
Mmm, irritating. I really don't get the error, and debug printouts confirm that it's because the directories .git/remotes and .git/branches both exist.
Your patch is the right thing to do anyway, obviously.
--
Karl Hasselström, kha@treskal.com
www.treskal.com/kalle