git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git-stash segfaults ...

From
Jeff King <peff@peff.net>
Date
Aug 21, 2007, 07:08 UTC
Message-ID
<20070821070809.GA8545@coredump.intra.peff.net>
In-Reply-To
<7v6439pecf.fsf@gitster.siamese.dyndns.org>
On Mon, Aug 20, 2007 at 11:54:24PM -0700, Junio C Hamano wrote:
> I think you were told that your patch was a band-aid for the
> symptom, and was not the real fix, in the thread you quoted.

To which I responded that it is still better to report an error than it is to segfault. In this case, the error message _isn't_ fixing the main problem, but at least it gives a better starting point for tracking problems than a segfault. Not to mention that it _does_ provide the correct error message in a variety of other situations (e.g., merge-recursive given bogus arguments).

But really, merge-recursive isn't generally called by users, and so it shouldn't get bogus input, so perhaps it isn't worth caring about.

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 7 in “git-stash segfaults ...”
  1. Pierre HabouzitAug 20, 2007
  2. Alex RiesenAug 20, 2007
  3. Jeff KingAug 21, 2007
  4. Junio C HamanoAug 21, 2007
  5. Jeff KingAug 21, 2007
  6. Junio C HamanoAug 20, 2007
  7. Pierre HabouzitAug 20, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.