git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git-stash segfaults ...

From
Jeff King <peff@peff.net>
Date
Aug 21, 2007, 06:05 UTC
Message-ID
<20070821060510.GA7323@coredump.intra.peff.net>
In-Reply-To
<20070820200255.GD5544@steel.home>
On Mon, Aug 20, 2007 at 10:02:55PM +0200, Alex Riesen wrote:
Show 13 quoted lines
> diff --git a/merge-recursive.c b/merge-recursive.c
> index 16f6a0f..464fc4e 100644
> --- a/merge-recursive.c
> +++ b/merge-recursive.c
> @@ -1701,6 +1701,8 @@ static struct commit *get_ref(const char *ref)
>  	if (get_sha1(ref, sha1))
>  		die("Could not resolve ref '%s'", ref);
>  	object = deref_tag(parse_object(sha1), ref, strlen(ref));
> +	if (!object)
> +		die("Could not resolve ref '%s' down to object", ref);
>  	if (object->type == OBJ_TREE)
>  		return make_virtual_commit((struct tree*)object,
>  			better_branch_name(ref));

I posted the exact same patch almost a month ago, but apparently nobody was interested in applying it:

  http://mid.gmane.org/20070726050726.GC32617@coredump.intra.peff.net
-Peff
Previous: Alex RiesenNext: Junio C Hamano
Message 3 of 7 in “git-stash segfaults ...”
  1. Pierre HabouzitAug 20, 2007
  2. Alex RiesenAug 20, 2007
  3. Jeff KingAug 21, 2007
  4. Junio C HamanoAug 21, 2007
  5. Jeff KingAug 21, 2007
  6. Junio C HamanoAug 20, 2007
  7. Pierre HabouzitAug 20, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.