From: Jeff King <peff@peff.net>
Date: Tue, 21 Aug 2007 07:08:09 GMT
Subject: Re: git-stash segfaults ...
Message-ID: <20070821070809.GA8545@coredump.intra.peff.net>
In-Reply-To: <7v6439pecf.fsf@gitster.siamese.dyndns.org>

On Mon, Aug 20, 2007 at 11:54:24PM -0700, Junio C Hamano wrote:

> I think you were told that your patch was a band-aid for the
> symptom, and was not the real fix, in the thread you quoted.

To which I responded that it is still better to report an error than it
is to segfault. In this case, the error message _isn't_ fixing the main
problem, but at least it gives a better starting point for tracking
problems than a segfault.  Not to mention that it _does_ provide the
correct error message in a variety of other situations (e.g.,
merge-recursive given bogus arguments).

But really, merge-recursive isn't generally called by users, and so it
shouldn't get bogus input, so perhaps it isn't worth caring about.

-Peff