Re: [PATCH 00/15] git-note: A mechanisim for providing free-form after-the-fact annotations on commits
- From
Johan Herland <johan@herland.net>
- Date
- May 28, 2007, 17:58 UTC
- Message-ID
- <200705281958.51079.johan@herland.net>
- In-Reply-To
- <20070528174205.GB7295@mellanox.co.il>
On Monday 28 May 2007, Michael S. Tsirkin wrote:
Show 9 quoted lines
> Quoting Michael S. Tsirkin <mst@dev.mellanox.co.il>:
> > Maybe note names could include the object they point to?
> > Would this help with the scalability too (i.e. only get
> > names for objects we want)?
>
> Hmm, I just noticed there's refs/notes/{object-sha}/{note-sha}
> that does exactly that. So - this seems to be clear to everyone
> else, but I seem to miss the reason why does this not scale well?
> We can just get the notes for objects we pull, right?Currently, only "git-note -l" (and by extension gitk) uses the shortcut through refs/notes/{object-sha}/...
The --decorate code and everybody else goes through for_each_note_ref() which looks up every note ref in the repo.
...Johan
-- Johan Herland, <johan@herland.net> www.herland.net