Re: [PATCH 00/15] git-note: A mechanisim for providing free-form after-the-fact annotations on commits

From: Johan Herland <johan@herland.net>
Date: May 28, 2007, 17:48 UTC
Message-ID: <200705281948.27329.johan@herland.net>
In-Reply-To: <alpine.LFD.0.98.0705280957070.26602@woody.linux-foundation.org>

On Monday 28 May 2007, Linus Torvalds wrote:

Show 12 quoted lines

> 
> On Mon, 28 May 2007, Johan Herland wrote:
> > 
> > I still don't see what makes note objects inherently more expensive than
> > commit objects. Except for the refs, of course, but we're getting rid
> > of those (at least replacing them with a more efficient reverse mapping).
> 
> It's exactly the refs that I worry about.
> 
> Anything that needs to read in all notes at startup is going to be _slow_.
> 
> In contrast, commits we read when (and only when) we need them.

Ok. But the reverse mapping will help with this, won't it? We'll look up the interesting commits and find their associated note objects directly.

BTW, if you use "git-note -l <commit>" it'll go directly to <commit>'s subdir in refs/notes and never look at any other notes.

Of course, this currently does not help the plumbing much, which uses for_each_note_ref() instead...

...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net