Re: [PATCH 01/10] Add a birdview-on-the-source-code section to the user manual

From: J. Bruce Fields <bfields@fieldses.org>
Date: May 15, 2007, 15:24 UTC
Message-ID: <20070515152457.GC6794@fieldses.org>
In-Reply-To: <20070515050808.GA11745@coredump.intra.peff.net>

On Tue, May 15, 2007 at 01:08:08AM -0400, Jeff King wrote:

Show 9 quoted lines

> However, the content-type is already specified, so it shouldn't need to
> rewrite. However, I notice that your original message is missing a
> MIME-Version: 1.0 header. My guess is that vger's logic is that without
> that header, it can't trust the Content-Type you have provided (and
> indeed, not including MIME-Version violates the MIME RFCs, I believe).
> 
> I assumed this was a bug in git-send-email, but looking closer, it
> doesn't put in any mime information at all! So your sending smtp server
> is adding in the content-type header,

Nope...

Show 6 quoted lines

> but it's failing to add the
> MIME-Version header, which I think is a bug (I can dig up the RFC
> reference if you want).
> 
> Arguably, git should be generating the full MIME header-set, since it
> knows what actual encoding the message is in.

... Yes. But actually, the Content-Type header is from git-format-patch:

$ git format-patch --stdout 12806b^..12806b |head
From 12806b65b0d1faec249002c51b871775dc344a47 Mon Sep 17 00:00:00 2001
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Date: Thu, 10 May 2007 12:36:15 +0200
Subject: [PATCH] Add a birdview-on-the-source-code section to the user
manual
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

In http://thread.gmane.org/gmane.comp.version-control.git/42479, a birdview on the source code was requested.

So it's a git-format-patch bug?

--b.