Re: [PATCH 01/10] Add a birdview-on-the-source-code section to the user manual

From: Karl Hasselström <kha@treskal.com>
Date: May 15, 2007, 08:24 UTC
Message-ID: <20070515082407.GA9096@diana.vm.bytemark.co.uk>
In-Reply-To: <20070515050808.GA11745@coredump.intra.peff.net>

On 2007-05-15 01:08:08 -0400, Jeff King wrote:

Show 6 quoted lines

> However, the content-type is already specified, so it shouldn't need
> to rewrite. However, I notice that your original message is missing
> a MIME-Version: 1.0 header. My guess is that vger's logic is that
> without that header, it can't trust the Content-Type you have
> provided (and indeed, not including MIME-Version violates the MIME
> RFCs, I believe).

You know, this rings a bell. I've discovered that a "MIME-Version: 1.0" is needed before. :-)

"stg mail" used to have the same problem, until it was changed to use the Python e-mail libraries for all that stuff. And since then I haven't had problems with it.

Show 8 quoted lines

> I assumed this was a bug in git-send-email, but looking closer, it
> doesn't put in any mime information at all! So your sending smtp
> server is adding in the content-type header, but it's failing to add
> the MIME-Version header, which I think is a bug (I can dig up the
> RFC reference if you want).
>
> Arguably, git should be generating the full MIME header-set, since
> it knows what actual encoding the message is in.

I very much agree.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle