git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Use GIT_OBJECT_DIR for temporary files of pack-objects

From
Alex Riesen <raa.lkml@gmail.com>
Date
May 7, 2007, 21:33 UTC
Message-ID
<20070507213347.GB3436@steel.home>
In-Reply-To
<56b7f5510705071051l75d701d7r94b7c4629cc425f@mail.gmail.com>
Dana How, Mon, May 07, 2007 19:51:24 +0200:
Show 8 quoted lines
> On 5/7/07, Alex Riesen <raa.lkml@gmail.com> wrote:
> >I'm not sure about fsck cleaning up after crashed/killed pack-objects:
> >not sure I _can_ detect if the temp files really are just leftovers.
> 
> It looks like you create temp file in objects , not objects/pack .
> 
> So a rule could be : packs left in the former are crashed/killed,
> and packs in the latter are complete?
How do you know for sure that they are _left_ already?
> You should also look at $PACKTMP in git-repack.sh .
> In it $GIT_DIR should probably be $GIT_OBJECT_DIRECTORY ?

I think it should, but it is already not the working directory, so my original complaint does not apply

Previous: Dana HowNext: Dana How
Message 10 of 11 in “repack: handling of .keep files”
  1. Alex RiesenMay 4, 2007
  2. Junio C HamanoMay 4, 2007
  3. Alex RiesenMay 4, 2007
  4. Junio C HamanoMay 4, 2007
  5. Alex RiesenMay 4, 2007
  6. Junio C HamanoMay 4, 2007
  7. Nicolas PitreMay 4, 2007
  8. Handle return code of parse_commit in revision machineryAlex Riesen, May 4, 2007
  9. Dana HowMay 7, 2007
  10. Alex RiesenMay 7, 2007
  11. Dana HowMay 7, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.