From: Alex Riesen <raa.lkml@gmail.com>
Date: Mon, 07 May 2007 21:33:47 GMT
Subject: Re: [PATCH] Use GIT_OBJECT_DIR for temporary files of pack-objects
Message-ID: <20070507213347.GB3436@steel.home>
In-Reply-To: <56b7f5510705071051l75d701d7r94b7c4629cc425f@mail.gmail.com>

Dana How, Mon, May 07, 2007 19:51:24 +0200:
> On 5/7/07, Alex Riesen <raa.lkml@gmail.com> wrote:
> >I'm not sure about fsck cleaning up after crashed/killed pack-objects:
> >not sure I _can_ detect if the temp files really are just leftovers.
> 
> It looks like you create temp file in objects , not objects/pack .
> 
> So a rule could be : packs left in the former are crashed/killed,
> and packs in the latter are complete?

How do you know for sure that they are _left_ already?

> You should also look at $PACKTMP in git-repack.sh .
> In it $GIT_DIR should probably be $GIT_OBJECT_DIRECTORY ?

I think it should, but it is already not the working directory, so my
original complaint does not apply