Re: repack: handling of .keep files

From: Alex Riesen <raa.lkml@gmail.com>
Date: May 4, 2007, 10:42 UTC
Message-ID: <81b0412b0705040342p4fed3a4bnee92cce6b5fb6b9@mail.gmail.com>
In-Reply-To: <7vy7k4ud3d.fsf@assigned-by-dhcp.cox.net>

On 5/4/07, Junio C Hamano <junkio@cox.net> wrote:

Show 12 quoted lines

> "Alex Riesen" <raa.lkml@gmail.com> writes:
>
> > ... Experimenting with the .keep-files I had a crash in git-log,
> > when the pack was renamed into .keep.pack, but the
> > index was not. git-log complained about two objects it could not
> > read and than crashed. It's cygwin.
>
> This part makes me suspect you are not even using the .keep
> properly.  In addition to pack-[0-9a-f]{40}.(pack|idx), you
> would have a corresponding pack-[0-9a-f]{40}.keep file (whose
> contents does not matter) to mark that these should not get
> repacked.

This is it (described in git-index-pack.txt, maybe git-repack.txt should reference it too), thanks.

Still, git-log shouldn't crash (nothing should, of course). And, the temporary pack is created in working tree, instead of in GIT_DIR (why not GIT_OBJECT_DIR, btw?)