git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Have git-revert, git-cherry-pick cleanup ./.msg upon successful completion.

From
Gerrit Pape <pape@smarden.org>
Date
May 7, 2007, 07:46 UTC
Message-ID
<20070507074655.14670.qmail@7aab74a0460bd8.315fe32.mid.smarden.org>
In-Reply-To
<20070505034615.GE16538@spearce.org>
On Fri, May 04, 2007 at 11:46:15PM -0400, Shawn O. Pearce wrote:
Show 8 quoted lines
> Gerrit Pape <pape@smarden.org> wrote:
> > git-revert and git-cherry-pick left behind the commit message file ./.msg,
> > have them use the -f option to git-commit to properly cleanup the
> > automatically created file.
> 
> I'm actually sort of against changing the behavior of git-commit
> -f to mean "delete the file".  We never did that before.  Users
> might get surprised when their file goes away!

-f never was documented AFAICS, only -F, and even though the file is gone, the commit message is available through git show then. I personally would like to have such an option to git commit regardless of revert and cherry-pick.

I concur with Alex that the teporary file should be in the git directory and not working directory.

Regards, Gerrit.
Previous: Junio C HamanoNext: Gerrit Pape
Message 8 of 10 in “git-commit -f <file>: take message from file, and remove file upon completion.”
  1. git-commit -f <file>: take message from file, and remove file upon completion.Gerrit Pape, May 4, 2007
  2. Have git-revert, git-cherry-pick cleanup ./.msg upon successful completion.Gerrit Pape, May 4, 2007
  3. Alex RiesenMay 4, 2007
  4. Shawn O. PearceMay 5, 2007
  5. Junio C HamanoMay 6, 2007
  6. Shawn O. PearceMay 8, 2007
  7. Junio C HamanoMay 8, 2007
  8. Gerrit PapeMay 7, 2007
  9. Have git-revert, git-cherry-pick use $GIT_DIR/COMMIT_MSG instead of ./.msg.Gerrit Pape, May 7, 2007
  10. git-commit: fix usage to show (-F|-f) <logfile>.Gerrit Pape, May 7, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.