git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Have git-revert, git-cherry-pick cleanup ./.msg upon successful completion.

From
Gerrit Pape <pape@smarden.org>
Date
May 4, 2007, 14:32 UTC
Message-ID
<20070504143210.8690.qmail@a4171e0dbe98e3.315fe32.mid.smarden.org>
In-Reply-To
<20070504143022.8539.qmail@4071cc1c178e73.315fe32.mid.smarden.org>

git-revert and git-cherry-pick left behind the commit message file ./.msg, have them use the -f option to git-commit to properly cleanup the automatically created file.

Signed-off-by: Gerrit Pape <pape@smarden.org>
---
 builtin-revert.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin-revert.c b/builtin-revert.c
index 4ba0ee6..9acdf47 100644
--- a/builtin-revert.c
+++ b/builtin-revert.c
@@ -376,10 +376,10 @@ static int revert_or_cherry_pick(int argc, const char **argv)
 
 	if (!no_commit) {
 		if (edit)
-			return execl_git_cmd("commit", "-n", "-F", ".msg",
+			return execl_git_cmd("commit", "-n", "-f", ".msg",
 				"-e", NULL);
 		else
-			return execl_git_cmd("commit", "-n", "-F", ".msg",
+			return execl_git_cmd("commit", "-n", "-f", ".msg",
 				NULL);
 	}
 	if (reencoded_message)
-- 
1.5.1.2
Previous: Gerrit PapeNext: Alex Riesen
Message 2 of 10 in “git-commit -f <file>: take message from file, and remove file upon completion.”
  1. git-commit -f <file>: take message from file, and remove file upon completion.Gerrit Pape, May 4, 2007
  2. Have git-revert, git-cherry-pick cleanup ./.msg upon successful completion.Gerrit Pape, May 4, 2007
  3. Alex RiesenMay 4, 2007
  4. Shawn O. PearceMay 5, 2007
  5. Junio C HamanoMay 6, 2007
  6. Shawn O. PearceMay 8, 2007
  7. Junio C HamanoMay 8, 2007
  8. Gerrit PapeMay 7, 2007
  9. Have git-revert, git-cherry-pick use $GIT_DIR/COMMIT_MSG instead of ./.msg.Gerrit Pape, May 7, 2007
  10. git-commit: fix usage to show (-F|-f) <logfile>.Gerrit Pape, May 7, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.