From: Gerrit Pape <pape@smarden.org>
Date: Mon, 07 May 2007 07:46:55 GMT
Subject: Re: [PATCH] Have git-revert, git-cherry-pick cleanup ./.msg upon successful completion.
Message-ID: <20070507074655.14670.qmail@7aab74a0460bd8.315fe32.mid.smarden.org>
In-Reply-To: <20070505034615.GE16538@spearce.org>

On Fri, May 04, 2007 at 11:46:15PM -0400, Shawn O. Pearce wrote:
> Gerrit Pape <pape@smarden.org> wrote:
> > git-revert and git-cherry-pick left behind the commit message file ./.msg,
> > have them use the -f option to git-commit to properly cleanup the
> > automatically created file.
> 
> I'm actually sort of against changing the behavior of git-commit
> -f to mean "delete the file".  We never did that before.  Users
> might get surprised when their file goes away!

-f never was documented AFAICS, only -F, and even though the file is
gone, the commit message is available through git show then.  I
personally would like to have such an option to git commit regardless of
revert and cherry-pick.

I concur with Alex that the teporary file should be in the git directory
and not working directory.

Regards, Gerrit.