Re: [PATCH 2/2] Add keyword unexpansion support to convert.c
- From
- Andy Parkins <andyparkins@gmail.com>
- Date
- Apr 17, 2007, 17:10 UTC
- Message-ID
- <200704171810.31797.andyparkins@gmail.com>
- In-Reply-To
- <Pine.LNX.4.64.0704170829500.5473@woody.linux-foundation.org>
On Tuesday 2007, April 17, Linus Torvalds wrote:
Show 5 quoted lines
> And think what we do about files (and whole subdirectories!) that > haven't even changed. And finally, think about how important that > optimization is in an SCM like git that supports branches. > > I think you'll find that keyword expansion simply isn't acceptable.
As I said in my reply to Junio; other VCSs only expand keywords when the file itself is checked out - when git's uber-fast switching decides that fileA is the same in the source and target checkouts, then the keywords won't be updated - fine.
In this one respect git would be "as good as" instead of "infinitely better". I can live with that.
> But hey, you didn't believe me, so I'm happy you are trying to write > the patches. Either you'll prove me wrong, or you'll realize just > *how* broken the feature is.
Could be - I'm happy to disagree. I'm even happy to accept that I might fail miserably.
Andy
-- Dr Andy Parkins, M Eng (hons), MIET andyparkins@gmail.com