Re: [PATCH] Hash name is SHA-1
- From
- Matthias Lederhofer <matled@gmx.net>
- Date
- Jan 25, 2007, 23:03 UTC
- Message-ID
- <20070125230302.GB13677@moooo.ath.cx>
- In-Reply-To
- <1169729410294-git-send-email-vonbrand@inf.utfsm.cl>
The patch should probably only change sha1 to SHA-1 and not reformat the initialisation of _usage arrays or the comments (new line before first line of comment). If the reformatting is desired it should be a separate patch imho. Here is what I found:
Horst H. von Brand <vonbrand@inf.utfsm.cl> wrote:
> +head this is "refs/heads/master". The two sha1 are the object names
> +called before the refname is updated, so either sha1-old is 0{40}
> +(meaning there is no such ref yet), or it should match what is
> +recorded in refname.sha1 -> SHA-1?
> -static const char commit_tree_usage[] = "git-commit-tree <sha1> [-p <sha1>]* < changelog"; > +static const char commit_tree_usage[] = > + "git-commit-tree <sha1> [-p <sha1>]* < changelog";
sha1 -> SHA-1?
Show 6 quoted lines
> -static const char read_tree_usage[] = "git-read-tree (<sha> | [[-m [--aggressive] | --reset | --prefix=<prefix>] [-u | -i]] [--exclude-per-directory=<gitignore>] <sha1> [<sha2> [<sha3>]])"; > +static const char read_tree_usage[] = > + "git-read-tree (<sha> | " > + "[[-m [--aggressive] | --reset | --prefix=<prefix>] " > + "[-u | -i]] [--exclude-per-directory=<gitignore>] " > + "<sha1> [<sha2> [<sha3>]])";
sha1 -> SHA-1, dunno what to do about the sha2 and sha3 :) There is also a space at eol.
The following have a space at eol and/or spaces instead of tabs for indenting.
> - /* New file in the index: it might actually be different in > + /* > + * New file in the index: it might actually be different in
> - /* dst is recorded as a modification of src. Are they so > + /* > + * dst is recorded as a modification of src. Are they so
> -/* We internally use unsigned short as the score value, > +/* > + * We internally use unsigned short as the score value,
> * and rely on an int capable to hold 32-bits. -B can take > - /* When cloning, it is not unusual to have > + /* > + * When cloning, it is not unusual to have
Show 6 quoted lines
> - /* If there is data present from a previous transfer attempt, > - resume where it left off */ > + /* > + * If there is data present from a previous transfer attempt, > + * resume where it left off > + */
Show 5 quoted lines
> - /* Input is non-recursive ls-tree output format > - * mode SP type SP sha1 TAB name > + /* > + * Input is non-recursive ls-tree output format > + * mode SP type SP SHA-1 TAB name