Re: [PATCH] Hash name is SHA-1

From: Shawn O. Pearce <spearce@spearce.org>
Date: Jan 25, 2007, 17:01 UTC
Message-ID: <20070125170120.GA13089@spearce.org>
In-Reply-To: <1169729410294-git-send-email-vonbrand@inf.utfsm.cl>

"Horst H. von Brand" <vonbrand@inf.utfsm.cl> wrote:

Show 10 quoted lines

> diff --git a/Documentation/git-receive-pack.txt b/Documentation/git-receive-pack.txt
> index 10e8c46..2fafc79 100644
> --- a/Documentation/git-receive-pack.txt
> +++ b/Documentation/git-receive-pack.txt
> @@ -20,7 +20,7 @@ The UI for the protocol is on the 'git-send-pack' side, and the
>  program pair is meant to be used to push updates to remote
>  repository.  For pull operations, see 'git-fetch-pack'.
>  
> -The command allows for creation and fast forwarding of sha1 refs
> +The command allows for creation and fast forwarding of SHA-1 refs

A good cleanup and correction. We've apparently been a little lax. Its a noble and worthy goal to make the correction and I applaud you for doing the hard work.

Show 14 quoted lines

> diff --git a/builtin-apply.c b/builtin-apply.c
> index 3fefdac..814f78f 100644
> --- a/builtin-apply.c
> +++ b/builtin-apply.c
> @@ -1811,7 +1812,8 @@ static int apply_binary(struct buffer_desc *desc, struct patch *patch)
>  			     "without full index line", name);
>  
>  	if (patch->old_name) {
> -		/* See if the old one matches what the patch
> +		/* 
> +		 * See if the old one matches what the patch
>  		 * applies to.
>  		 */
>  		hash_sha1_file(desc->buffer, desc->size, blob_type, sha1);

However I cannot help but feel that this hunk is unrelated to the theme of this extremely large patch. I don't know how Junio feels, but this late in the 1.5.0 series I'm a little leary of a 1600+ line patch which is changing so much code, even if its something as trivial as the above hunk.

-- 
Shawn.