Re: [PATCH] Hash name is SHA-1

From: Shawn O. Pearce <spearce@spearce.org>
Date: Jan 25, 2007, 19:05 UTC
Message-ID: <20070125190516.GD13089@spearce.org>
In-Reply-To: <200701251856.l0PIu8pP032403@laptop13.inf.utfsm.cl>

"Horst H. von Brand" <vonbrand@inf.utfsm.cl> wrote:

Show 6 quoted lines

> Nicolas Pitre <nico@cam.org> wrote:
> > Maybe the patch could be restricted to documentation fixes only for now?
> 
> That's what I tried to do. But just changing the documentation without
> changing (some) of the messages and so on just gets you worse
> inconsistency.

I'm not at all against updating output messages to match the documentation. Indeed, its good to make them consistent.

It just would be a lot easier to review the patch if it wasn't 1600+ lines, _especially_ when some of the hunks really aren't related to the theme of the patch.

Of course with the amount of time I've now spent writing email saying how hard it is to review the original patch, I could have just read through the entire thing and given it another set of eyeballs. Argh, another great misuse of my time. :-)

-- 
Shawn.