git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Checking for "diff.color." should come before "diff.color"

From
Jeff King <peff@peff.net>
Date
Oct 23, 2006, 20:29 UTC
Message-ID
<20061023202952.GC31068@coredump.intra.peff.net>
In-Reply-To
<200610232051.17396.andyparkins@gmail.com>
On Mon, Oct 23, 2006 at 08:51:17PM +0100, Andy Parkins wrote:
> In git_diff_ui_config() the strncmp() for "diff.color" would have
> matched for "diff.color.", so "diff.color." configs would never be
> processed.

No, it's a strcmp for "diff.color", so it must match exactly. The code is fine.

Are you experiencing some bug, or was this just from poking through the code?

-Peff
Previous: Andy ParkinsNext: Andy Parkins
Message 2 of 5 in “Checking for "diff.color." should come before "diff.color"”
  1. Checking for "diff.color." should come before "diff.color"Andy Parkins, Oct 23, 2006
  2. Jeff KingOct 23, 2006
  3. Andy ParkinsOct 23, 2006
  4. Jeff KingOct 23, 2006
  5. Andy ParkinsOct 23, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.