git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Checking for "diff.color." should come before "diff.color"

From
APAndy Parkins <andyparkins@gmail.com>
Date
Oct 23, 2006, 21:03 UTC
Message-ID
<200610232203.40510.andyparkins@gmail.com>
In-Reply-To
<7vk62qydvu.fsf@assigned-by-dhcp.cox.net>
On Monday 2006, October 23 21:29, Junio C Hamano wrote:
Show 7 quoted lines
> Andy Parkins <andyparkins@gmail.com> writes:
> > In git_diff_ui_config() the strncmp() for "diff.color" would have matched
> > for "diff.color.", so "diff.color." configs would never be processed.
>
> A test case that demonstrates the breakage without the patch
> would be nice. Could you come up with a two-patch series that
> is:

No need. Jeff King already caught the fact that my patch is unnecessary. I withdraw it.

Sorry to keep bothering you all with these non-entity patches. I really am only trying to help :-)

Andy
-- 
Dr Andrew Parkins, M Eng (Hons), AMIEE
andyparkins@gmail.com
Previous: Jeff King
Message 5 of 5 in “Checking for "diff.color." should come before "diff.color"”
  1. Checking for "diff.color." should come before "diff.color"Andy Parkins, Oct 23, 2006
  2. Jeff KingOct 23, 2006
  3. Andy ParkinsOct 23, 2006
  4. Jeff KingOct 23, 2006
  5. Andy ParkinsOct 23, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.