From: Jeff King <peff@peff.net>
Date: Mon, 23 Oct 2006 20:29:53 GMT
Subject: Re: [PATCH] Checking for "diff.color." should come before "diff.color"
Message-ID: <20061023202952.GC31068@coredump.intra.peff.net>
In-Reply-To: <200610232051.17396.andyparkins@gmail.com>

On Mon, Oct 23, 2006 at 08:51:17PM +0100, Andy Parkins wrote:

> In git_diff_ui_config() the strncmp() for "diff.color" would have
> matched for "diff.color.", so "diff.color." configs would never be
> processed.

No, it's a strcmp for "diff.color", so it must match exactly. The code
is fine.

Are you experiencing some bug, or was this just from poking through the
code?

-Peff